Set Filter description to describe what the filter allows instead of … #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…what is filtered out
cijothomas
reviewed
Nov 24, 2020
cijothomas
reviewed
Nov 25, 2020
cijothomas
approved these changes
Nov 25, 2020
|
@kevinmckinley Thanks! Will you be fixing the other instrumentation docs as well to the same wordings? |
|
ok to merge, doc clarification only. |
I'd be happy to. Are there any other places that I should look? |
|
No. Just OpenTelemetry.Instrumentation.* will cover all. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reword the description and example for Filter to describe it's purpose which is to define what is allowed instead of what is removed.
Issue driving the change: #1186
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes